take it back, take it way back #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
switch from data/rds to pbp/rds data repo path
saiemgilani
added a commit
that referenced
this pull request
Jun 29, 2021
take it back, take it way back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected points and Win Probability data back to 2003
Added to the package functions
load_cfb_pbp()andupdate_cfb_db()There are a few known errors with the calculations that need to be looked into further. One specific one identified by Brendan Farrell noting that short yardage touchdowns for pre-2008 data were often negative EPA plays. This is either a duplication issue or a coding error.
switch from data/rds to pbp/rds data repo path