feat!: refactor context provider #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicklasl
requested review from
fabriziodemaria,
nickybondarenko and
vahidlazio
as code owners
Confidence/src/main/java/com/spotify/confidence/ConfidenceDeviceInfoContextProducer.kt
Outdated
Show resolved
Hide resolved
Confidence/src/main/java/com/spotify/confidence/ConfidenceDeviceInfoContextProducer.kt
Show resolved
Hide resolved
nicklasl
force-pushed
the
refactor-context-provider
branch
from
10d554e to
b7477c5
Compare
nickybondarenko
previously approved these changes
Jan 27, 2025
Confidence/src/main/java/com/spotify/confidence/ConfidenceDeviceInfoContextProducer.kt
Outdated
Show resolved
Hide resolved
nicklasl
commented
Jan 28, 2025
andreas-karlsson
previously approved these changes
Jan 28, 2025
nickybondarenko
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main work here is to stop exposing the
AndroidLifecycleEventProducerand to restructure how we expose the ?Producerinterface.Keeping multiple breaking changes in one PR.