Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cocoapods support #124

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add cocoapods support #124

wants to merge 3 commits into from

Conversation

camiletti
Copy link

@camiletti camiletti commented May 8, 2019 •
edited
Loading

I thought it would be great if the Spotify SDK would be officially available on CocoaPods as it makes dependency management so much easier

Checklist if approved:

  • Push to CocoaPods trunk
  • Change pod version to reflect the next release

@ilijapuaca
Copy link

Any plans on merging this in?

It would be a major improvement over having to embed a 42Mb framework, that then sits in your repo unless you want to deal with submodules.

thejohnlima
thejohnlima reviewed Mar 20, 2020
View reviewed changes
Spotify-SDK.podspec Outdated
Pod::Spec.new do |s|

s.name = "Spotify-SDK"
s.version = "1.0.2"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The currently latest version is 1.2.2

@thejohnlima
Copy link

Were you be able to get the build works after run pod install?

Podfile:
pod 'Spotify-SDK', :git => 'https://github.com/camiletti/spotify-ios-sdk.git', :branch => 'add-cocoapods-support'

I'm getting a build failed:
Screen Shot 2020-03-20 at 7 42 54 PM

@glenna
Copy link

glenna commented May 22, 2020

Also would love to have this :)

@fotiDim fotiDim mentioned this pull request Jul 31, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thejohnlima thejohnlima thejohnlima left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@camiletti @ilijapuaca @thejohnlima @glenna