Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't segfault on zero-channel MP3s. #381

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Don't segfault on zero-channel MP3s. #381

merged 3 commits into from
Nov 6, 2024

Conversation

psobot
Copy link
Member

@psobot psobot commented Nov 4, 2024

Fixes #379.

@psobot psobot added the bug Something isn't working label Nov 4, 2024
@psobot psobot mentioned this pull request Nov 5, 2024
Closed
tdhopper
tdhopper approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@tdhopper tdhopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it

@psobot psobot merged commit 1273304 into master Nov 6, 2024
35 checks passed
@psobot psobot deleted the psobot/handle-zero-channel-mp3s branch November 6, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdhopper tdhopper tdhopper approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pedalboard 0.9.16 segfaults on MP3 (attached)
2 participants
@psobot @tdhopper