Fix some warnings and add command line parsing for unordered field keys #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #330 +/- ##
==========================================
+ Coverage 71.06% 71.10% +0.04%
==========================================
Files 35 35
Lines 1441 1450 +9
Branches 115 120 +5
==========================================
+ Hits 1024 1031 +7
- Misses 417 419 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
This fixes #103 |
idreeskhan
commented
Oct 9, 2020
| | --lhs=<path> LHS File path or BigQuery table | ||
| | --rhs=<path> RHS File path or BigQuery table | ||
| | --output=<output> File path prefix for output | ||
| | --ignore=<keys> ',' separated field list to ignore | ||
| | --unordered=<keys> ',' separated field list to treat as unordered | ||
| | --unorderedFieldKey=<key> ',' separated list of keys for fields which are unordered nested records. Mappings use '->' |
There was a problem hiding this comment.
Thinking of switching this to : delimited
There was a problem hiding this comment.
I like : better than ->
anne-decusatis
approved these changes
Oct 9, 2020
| | --lhs=<path> LHS File path or BigQuery table | ||
| | --rhs=<path> RHS File path or BigQuery table | ||
| | --output=<output> File path prefix for output | ||
| | --ignore=<keys> ',' separated field list to ignore | ||
| | --unordered=<keys> ',' separated field list to treat as unordered | ||
| | --unorderedFieldKey=<key> ',' separated list of keys for fields which are unordered nested records. Mappings use '->' |
There was a problem hiding this comment.
I like : better than ->
| @@ -240,6 +242,15 @@ class BigDiffyTest extends PipelineSpec { | |||
| keyValues.toString shouldBe "foo_bar" | |||
| } | |||
|
|
|||
| "BigDiffy unorderedKeysMap" should "work with multiple unordered keys" in { | |||
| val keyMappings = List("record.nested_record->key", "record.other_nested_record->other_key") | |||
| val unorderdKeys = BigDiffy.unorderedKeysMap(keyMappings) | |||
There was a problem hiding this comment.
nitpick: typo, unordered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't know if this is a good idea or not but it was annoying to me to have to import ratatool as a dependency just to use this feature (and therefore commit diff jobs into a pipeline repo). Basically allows
->demarcated field key mappings for nested records that can be ',' delimited to specify multiple field mappings. Let me know what you think