Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prune C++ tests to speed up build #101

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Prune C++ tests to speed up build #101

merged 2 commits into from
Dec 13, 2024

Conversation

stephen29xie
Copy link
Contributor

@stephen29xie stephen29xie commented Dec 13, 2024 •
edited
Loading

Description

The C++ tests are flaky and slowing down the CI build.

Related Issues

Changes Made

C++

  • Reduce the number of vectors and number of dimensions in the C++ tests for faster runs
    • This should also improve the flakiness because we are more likely to observe values outside of the allowed precision error in high volume indices and queries.
  • Remove test that checks for a RecallError. This is actually the bigger offender because it needed a large number of nodes in the HNSW graph to reproduce a disconnected graph

Testing

Checklist

  • My code follows the code style of this project.
  • I have added and/or updated appropriate documentation (if applicable).
  • All new and existing tests pass locally with these changes.
  • I have run static code analysis (if available) and resolved any issues.
  • I have considered backward compatibility (if applicable).
  • I have confirmed that this PR does not introduce any security vulnerabilities.

Additional Comments

@stephen29xie stephen29xie marked this pull request as ready for review December 13, 2024 19:58
dylanrb123
dylanrb123 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@dylanrb123 dylanrb123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@stephen29xie stephen29xie merged commit 2eb361d into main Dec 13, 2024
57 checks passed
@stephen29xie stephen29xie deleted the stephenx/prune-cpp-tests branch December 13, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylanrb123 dylanrb123 dylanrb123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephen29xie @dylanrb123