Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regen java docs #104

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Regen java docs #104

merged 3 commits into from
Dec 17, 2024

Conversation

stephen29xie
Copy link
Contributor

@stephen29xie stephen29xie commented Dec 17, 2024 •
edited
Loading

Description

Java docs on https://spotify.github.io/voyager/java/ are not rendering as expected

Related Issues

Java

Regenerate the Java docs since maven-javadoc-plugin was pinned to 3.7.0.

Testing

Previewed the docs locally. They look correct now.

Checklist

  • My code follows the code style of this project.
  • I have added and/or updated appropriate documentation (if applicable).
  • All new and existing tests pass locally with these changes.
  • I have run static code analysis (if available) and resolved any issues.
  • I have considered backward compatibility (if applicable).
  • I have confirmed that this PR does not introduce any security vulnerabilities.

Additional Comments

dylanrb123
dylanrb123 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@dylanrb123 dylanrb123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good I think 🤷 was the change here just to run with a newer version of java?

@stephen29xie
Copy link
Contributor Author

I reran this with Java 17 and it still works. Not sure what went wrong before

@stephen29xie stephen29xie merged commit af3c0e9 into main Dec 17, 2024
57 checks passed
@stephen29xie stephen29xie deleted the stephenx/fix-javadocs branch December 17, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylanrb123 dylanrb123 dylanrb123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephen29xie @dylanrb123