Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix benchmarks failing in github CI #105

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

miclegr
Copy link
Contributor

@miclegr miclegr commented Dec 18, 2024

Description

Currently benchmarks are failing when ran in github CI because we are checking out the doctest git submodule via ssh, without having a valid ssh key.

Changes Made

Since doctest it's a public repo, we can just use the https checkout, which does not require any authentication

@miclegr miclegr marked this pull request as ready for review December 18, 2024 17:07
Copy link
Contributor

@stephen29xie stephen29xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@miclegr miclegr merged commit 1cf25c3 into spotify:main Dec 19, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants