Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for PHP 8.0 | Add support for PHP 8.4 #265

Merged
merged 10 commits into from
Nov 22, 2024
Merged

Conversation

sprain
Copy link
Owner

@sprain sprain commented Nov 10, 2024

  • Drops support for PHP 8.0
  • Adds support for PHP 8.4
  • Adds modernizations available from PHP 8.1
  • Adds policy on how long PHP versions and dependencies are supported

@kohlerdominik
Copy link
Contributor

kohlerdominik commented Nov 10, 2024

This library supports a PHP version as long as it accounts for at least 10% of current installations

@sprain While this stat is interessting for a general overview, I wouldn't assume its use based on the install count (read: composer install). There might be pipelines that run on every commit and therefore dozens of installs per week per developer (like ours). This does not really represent it's real "use".

edit: also, if we're developing small features, there are a lot more commits (=installs) than if we develop on a huge feature.

@sprain
Copy link
Owner Author

sprain commented Nov 10, 2024

@kohlerdominik Thanks for the feedback.

I would handle this number flexibly. If based on installs one can assume that the number of real use cases is below 10%, dropping a version becomes an option. It serves an indicator for decision making.

In the past I dropped a few dependencies too soon, which caused issues for some users. I accept the challenge to avoid repeating this :)

@sprain sprain changed the title Drop support for PHP 8.0 Drop support for PHP 8.0 | Add support for PHP 8.4 Nov 20, 2024
@sprain sprain merged commit f09a0d9 into master Nov 22, 2024
18 checks passed
@sprain sprain deleted the drop-php-80 branch November 22, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants