Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference error classes from the core bundle in fetchers #332

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tniezg
Copy link
Contributor

@tniezg tniezg commented Feb 2, 2022

For instanceof to properly recognize errors in the HTTP class, fetchers need to reference errors from @spree/storefront-api-v2-sdk and not from sources.

For `instanceof` to properly recognize errors in the `HTTP` class,
fetchers need to reference errors from `@spree/storefront-api-v2-sdk`
and not from sources which duplicates error classes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant