This repository has been archived by the owner on Jun 7, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @mtravnicek, sorry for the misunderstanding.
It's a subtle change, so I understand why you missed it. Let me see if I can shed some light on the problem.
The tutorial has snippets that refer to actual code. The full configuration for the
frontend-maven-plugin
used to live in thebasic
module's POM, but at some point, that configuration was pulled up to the parent POM so that it could be shared with the other modules.When that configuration got pulled up, it didn't break the functionality of the
basic
module, but it did break the tutorial, because those following along now can't tell what to put for configuration in the<plugin>
element—all they get is a blank plugin configuration.To fix the problem, I told the tutorial to look at the parent POM (
../pom.xml
) instead of the POM in thebasic
module (pom.xml
). It even already had the tags delineating the plugin section.Thanks for commenting! If you're seeing a problem I'm not, feel free to clarify further.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mtravnicek, when I run the
basic
module, from the original repo, it works as expected. Does it work for you?