Skip to content
This repository has been archived by the owner on Jun 7, 2024. It is now read-only.

Fixes frontend-maven-plugin snippet in basic module. #130

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion basic/README.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ This section contains the barebones information to get the JavaScript bits off t
====
[source,xml,indent=0]
----
include::pom.xml[tag=frontend-maven-plugin]
include::../pom.xml[tag=frontend-maven-plugin]
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @mtravnicek, sorry for the misunderstanding.

i dont even see any relevant file being commited...

It's a subtle change, so I understand why you missed it. Let me see if I can shed some light on the problem.

The tutorial has snippets that refer to actual code. The full configuration for the frontend-maven-plugin used to live in the basic module's POM, but at some point, that configuration was pulled up to the parent POM so that it could be shared with the other modules.

When that configuration got pulled up, it didn't break the functionality of the basic module, but it did break the tutorial, because those following along now can't tell what to put for configuration in the <plugin> element—all they get is a blank plugin configuration.

image

To fix the problem, I told the tutorial to look at the parent POM (../pom.xml) instead of the POM in the basic module (pom.xml). It even already had the tags delineating the plugin section.

Thanks for commenting! If you're seeing a problem I'm not, feel free to clarify further.

Copy link
Author

@UgmaDevelopment UgmaDevelopment Jan 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mtravnicek, when I run the basic module, from the original repo, it works as expected. Does it work for you?

----
====

Expand Down