Refactor k8s client configuration watcher #1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
…k8s_client_configuration_watcher
Signed-off-by: wind57 <[email protected]>
wind57
commented
Jan 31, 2025
| @@ -1,9 +0,0 @@ | |||
| apiVersion: v1 | |||
| data: | |||
| application.properties: |- | |||
There was a problem hiding this comment.
it was used to configure the configuration watcher and I moved those properties to env variables
wind57
commented
Jan 31, 2025
| @@ -34,7 +34,7 @@ | |||
| <properties> | |||
| <kubernetes-fabric8-client.version>6.9.2</kubernetes-fabric8-client.version> | |||
| <kubernetes-native-client.version>19.0.2</kubernetes-native-client.version> | |||
| <wiremock.version>3.4.2</wiremock.version> | |||
There was a problem hiding this comment.
minor upgrade, safe since it is used only in tests
wind57
commented
Jan 31, 2025
| @@ -22,8 +22,8 @@ | |||
| import io.fabric8.kubernetes.api.model.Service; | |||
| import io.fabric8.kubernetes.api.model.apps.Deployment; | |||
| import io.fabric8.kubernetes.client.utils.Serialization; | |||
| import org.assertj.core.api.Assertions; | |||
There was a problem hiding this comment.
using assertj assertions
wind57
commented
Jan 31, 2025
| @@ -92,129 +81,45 @@ void after() { | |||
| } | |||
|
|
|||
| /* | |||
| * this test loads uses two services: wiremock on port 8080 and configuration-watcher | |||
There was a problem hiding this comment.
I've tried to simplify tests a bit here, but did not change the logical behind them at all.
I did drop one overlapping tests here though :)
wind57
commented
Jan 31, 2025
| .isEmpty()); | ||
| WireMock.verify(WireMock.exactly(4), WireMock.postRequestedFor(WireMock.urlEqualTo("/actuator/refresh"))); | ||
| createSecret(util, LEFT_NAMESPACE); | ||
| createSecret(util, RIGHT_NAMESPACE); |
There was a problem hiding this comment.
the logic did not change at all, I just cleaned up things
|
@ryanjbaxter last PR I have in my queue, it refactors one more integration test. thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.