Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change to WebEnvironment.MOCK in tests. #113

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

manolo
Copy link
Contributor

@manolo manolo commented May 2, 2024

It fixes migration to next vaadin version 24.4.x
See: vaadin/hilla#2169

It fixes migration to next vaadin version 24.4.x
See: vaadin/hilla#2169
@robertmcnees
Copy link
Contributor

Hi @manolo! Is the webEnvironment parameter is required at all? Removing the parameter completely has no impact on the tests. Looking at MainViewTests, I can't see the need for a server to start.

The tests in MainViewTests (and also CrudWithVaadinApplicationTests) look like unit tests similar to these tests as referenced in this guide. These tests look different than the end to end tests defined in this class and this section of the guide that do require a server to start. I can't see any end to end tests in this repo.

If this issue shows up in 24.4, perhaps we can address this PR with an upcoming version bump of Vaadin. It looks like 24.4 is due out this month. What do you think?

@ZheSun88
Copy link
Contributor

ZheSun88 commented Jun 12, 2024

Hi, @robertmcnees here is the PR to upgrade this project to Vaadin 24.4, and it needs this fix to pass.
#115

@robertmcnees robertmcnees merged commit 8164462 into spring-guides:main Jun 12, 2024
1 check passed
@robertmcnees
Copy link
Contributor

Thanks for the PR @manolo and the context @ZheSun88. I merged this PR so that the tests would pass when upgrading the Vaadin version to 24.4.1.

This repository is now managed by dependabot so if a scenario like this arises again we should be able to push additional commits to the dependabot PR when the CI build fails. Hopefully that makes our workflow easier to sustain going forward.

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants