-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PA-4774 extended WhoamiV1 interface for Wonderwal #71
Conversation
we shouldn't go the way of a callback function, we should use Events. for this reason: https://stackoverflow.com/questions/50865614/can-i-pass-function-as-attribute-to-web-component |
Not necessarily for this function. The function itself could listen for the event when rendering the wonderwall and thus make it a bit easier for integrators. Its basically how wonderwall itself works or the ensureFirstNameLastName. They create a listener (in that case for post message) and then render the component to encapsulate the functionality. Imo the function being a promise would be the nicer way instead of a callback though. Its basically the same just a little more flexible. |
No description provided.