Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker compose environment parsing for bitnami images #43771

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hezean
Copy link
Contributor

@hezean hezean commented Jan 10, 2025

This PR is related to bitnami images support under spring-boot-docker-compose.

Changes

  • bitnami/postgresql: fix incorrect environment variable keys:

    • POSTGRESQL_USER -> POSTGRESQL_USERNAME
    • POSTGRESQL_DB -> POSTGRESQL_DATABASE
  • ALLOW_EMPTY_PASSWORD: fix boolean matching method to be consistent with bitnami/libvalidations.sh@is_boolean_yes, affected images:

    • bitnami/clickhouse
    • bitnami/mariadb
    • bitnami/mysql
    • bitnami/postgresql (newly added)

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants