-
Notifications
You must be signed in to change notification settings - Fork 38.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize BeanMap#entrySet
#33793
Optimize BeanMap#entrySet
#33793
Conversation
@gudrb33333 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
1 similar comment
@gudrb33333 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@gudrb33333 Thank you for signing the Contributor License Agreement! |
I see a remaining |
Do you mean using a Set directly without copying it into a HashMap? |
Yes |
519b962
to
7b01258
Compare
I researched and discovered SimpleImmutableEntry, then modified the code to directly use Collections.unmodifiableSet(). |
Thanks, make sense, but I initially missed those changes were done on the CGLIB fork that is included in Spring Framework, and we prefer avoiding doing such refinement on the fork, so I will decline. Thanks for your understanding. |
Thank you for the review! It was very motivating for me. |
Hello, I have been learning a lot while analyzing this open source project recently. During my analysis, I noticed a TODO message and came up with an simple idea.
I have read the contributor guidelines in detail, but there may still be some mistakes.