Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented logging for LDAP searches performed by LdapTemplate #764

Merged
merged 4 commits into from
Feb 2, 2024

Conversation

Haarolean
Copy link
Contributor

Hi,

I've implemented some logging for LDAP searches performed within LdapTemplate. Resolves #345.
I believe this will help and greatly improve the experience using spring-ldap, as the issues people (and I personally) encounter usually are hard to debug or investigate.

  1. I've extracted some common parts to reduce/prevent code duplications and added logging there;
  2. I've spotted some straight-to-fix warnings and some anonymous classes with lambdas, so I took the liberty. These changes can be viewed independently within one of the two commits in this PR. Let me know if these changes are unwanted, and I'll revert.
  3. The test run is successful: BUILD SUCCESSFUL in 1m 44s; 67 actionable tasks: 57 executed, 10 up-to-date

Cheers

@Haarolean
Copy link
Contributor Author

@jzheaux hey, sorry for the ping. Is there anything else I could do here to add some traction to the PR?
I'd even apply for a position at VMware to help out with maintenance stuff but they're not hiring atm :-))

@jzheaux
Copy link
Contributor

jzheaux commented Feb 1, 2024

@Haarolean, sorry for the delay. I'm taking a look this week.

@jzheaux jzheaux added this to the 3.2.2 milestone Feb 2, 2024
@jzheaux jzheaux merged commit 2f3d934 into spring-projects:main Feb 2, 2024
2 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented Feb 2, 2024

Thanks, @Haarolean! This is now merged into main.

@Haarolean
Copy link
Contributor Author

@jzheaux thank you!

@Haarolean Haarolean deleted the issues/345 branch February 2, 2024 20:43
@ranma2913
Copy link

Thanks for adding this. It's going to help out my project right away since I'm working on running native queries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

LDAP-310: Log LDAP queries generated by spring-ldap
3 participants