Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactive oauth2Login should pick up OAuth2ReactiveUserService bean #15848

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Reactive oauth2Login should pick up OAuth2ReactiveUserService bean #15848

merged 1 commit into from
Oct 14, 2024

Conversation

kse-music
Copy link
Contributor

Closes gh-15846

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 25, 2024
@jzheaux jzheaux self-assigned this Sep 30, 2024
@jzheaux jzheaux added in: config An issue in spring-security-config and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 30, 2024
jzheaux
jzheaux requested changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kse-music! Please see my feedback inline.

config/src/main/java/org/springframework/security/config/web/server/ServerHttpSecurity.java Show resolved Hide resolved
@kse-music kse-music requested a review from jzheaux October 7, 2024 12:21
@jzheaux jzheaux added the type: enhancement A general enhancement label Oct 14, 2024
@jzheaux jzheaux added this to the 6.4.0-RC1 milestone Oct 14, 2024
@jzheaux jzheaux merged commit ef1226d into spring-projects:main Oct 14, 2024
6 checks passed
@jzheaux jzheaux changed the title Auto config OidcReactiveOAuth2UserService When Oauth2UserService bean is Present Reactive oauth2Login should pick up OAuth2ReactiveUserService bean Oct 14, 2024
@jzheaux
Copy link
Contributor

jzheaux commented Oct 14, 2024

Thanks, @kse-music! This is now merged into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: config An issue in spring-security-config type: enhancement A general enhancement
Projects
None yet
Milestone
6.4.0-RC1
Development

Successfully merging this pull request may close these issues.

Inconsistent ReactiveOAuth2UserService in OAuth2LoginSpec
3 participants
@kse-music @jzheaux @spring-projects-issues