Add Reactive One-Time Token Login Kotlin DSL Support #15888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
added
in: config
|
Thanks, @CrazyParanoid! While we are here, will you please do a quick review on the existing Kotlin documentation samples to ensure that they align with your changes? Some of them look like they should be adjusted. |
franticticktick
force-pushed
the
gh-15887
branch
4 times, most recently
from
efde077
to
ec314ee
Compare
|
@jzheaux I tried to eliminate the consequences of renaming the API, perhaps I could have missed something somewhere. Could you please review this PR? |
|
Thanks for the additional updates, @CrazyParanoid. Are you able to isolate the Kotlin DSL support changes to a separate commit from the rest? That way it's clear in the commit log what was needed for which feature. |
The names of variables and methods have been adjusted in accordance with the names of the one-time token login API components. Issue spring-projectsgh-15114
franticticktick
force-pushed
the
gh-15887
branch
from
ec314ee
to
814ab46
Compare
|
Thanks, @CrazyParanoid! This is now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-15887