-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error when Bearer token is requested with empty string #15940
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jacknie84, thanks for the PR! Please see comment below. Also there are failures on the build. Let me know if you need any assistance with the build output.
...org/springframework/security/oauth2/server/resource/web/DefaultBearerTokenResolverTests.java
Show resolved
Hide resolved
Hi @sjohnr. Thank you for your review. |
@@ -217,6 +217,19 @@ void resolveWhenQueryParameterHasMultipleAccessTokensThenOAuth2AuthenticationExc | |||
|
|||
} | |||
|
|||
@Test | |||
public void resolveWhenQueryParameterIsPresentAndEmptyStringThenTokenIsNotResolved() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is the same test as resolveWhenQueryParameterIsEmptyAndSupportedThenOAuth2AuthenticationException()
? I think this test isn't needed?
Issue gh-15885