Fix error when Bearer token is requested with empty string #15940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
sjohnr
requested changes
Oct 18, 2024
There was a problem hiding this comment.
Hi @jacknie84, thanks for the PR! Please see comment below. Also there are failures on the build. Let me know if you need any assistance with the build output.
...org/springframework/security/oauth2/server/resource/web/DefaultBearerTokenResolverTests.java
Show resolved
Hide resolved
|
Hi @sjohnr. Thank you for your review. |
jzheaux
added
in: oauth2
sjohnr
reviewed
Oct 24, 2024
| @@ -217,6 +217,19 @@ void resolveWhenQueryParameterHasMultipleAccessTokensThenOAuth2AuthenticationExc | |||
|
|
|||
| } | |||
|
|
|||
| @Test | |||
| public void resolveWhenQueryParameterIsPresentAndEmptyStringThenTokenIsNotResolved() { | |||
There was a problem hiding this comment.
I believe this is the same test as resolveWhenQueryParameterIsEmptyAndSupportedThenOAuth2AuthenticationException()? I think this test isn't needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue gh-15885