Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update defaults of allowMultipleExpanded and allowZeroExpanded to true #366

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
- Revert intergration test case to use defaults (noting the defaults …
…have changed).

- Remove integration test that was testing the old default, rather than the correct behaviour.
liamjohnston committed Aug 23, 2023
commit 44e2c1de145bb52f7ebecbb63df80a4ed3dc652f
2 changes: 1 addition & 1 deletion integration/src/index.tsx
Original file line number Diff line number Diff line change
@@ -10,7 +10,7 @@ import {

ReactDOM.render(
<div id="classic-accordion">
<Accordion allowMultipleExpanded={false} allowZeroExpanded={false}>
<Accordion>
<AccordionItem>
<AccordionItemHeading>
<AccordionItemButton>Heading One</AccordionItemButton>
17 changes: 0 additions & 17 deletions integration/wai-aria.spec.js
Original file line number Diff line number Diff line change
@@ -365,23 +365,6 @@ describe('WAI ARIA Spec', () => {
}
});

it(`If the accordion panel associated with an accordion header is
visible, and if the accordion does not permit the panel to be
collapsed, the header button element has aria-disabled set to true.`, async () => {
const { browser, page, buttonsHandles } = await setup();
expect(buttonsHandles.length).toEqual(3);

const firstButtonHandle = buttonsHandles[0];
await firstButtonHandle.click();

const buttonAriaDisabled = await page.evaluate(
(button) => button.getAttribute('aria-disabled'),
firstButtonHandle,
);

expect(buttonAriaDisabled).toEqual('true');
});

it(`Optionally, each element that serves as a container for panel
content has role region and aria-labelledby with a value that refers
to the button that controls display of the panel.`, async () => {