✨Feat: 이달의 컴포넌트 UI 구현 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
버튼 디자인 빼고
|
🎉 구현한 기능 Preview: https://fandom-7gj019y7q-easyhyun00s-projects.vercel.app |
easyhyun00
approved these changes
May 7, 2024
Comment on lines
9
to
11
| if (window.innerWidth > 744) { | ||
| setsNumOfItemsToShow(numberOfItems[0]); | ||
| } else if (window.innerWidth > 375) { |
There was a problem hiding this comment.
제가 constants/screenSizes.js 에 화면 사이즈를 상수화 했는데 그거 가져와서 사용하는 게 좋을 것 같습니다!
src/assets/icons/Chart.jsx
Outdated
| > | ||
| <path | ||
| d="M8 10.5L8 16.5" | ||
| stroke="white" |
There was a problem hiding this comment.
컴포넌트로 너무 잘 만들어주셨어요!
그런데 얘는 색상이 stroke="white" 로 되어 있으니깐
props 로 stroke="white" 이렇게 하고 stroke={stroke} 이렇게 하셔야 합니다!
src/utils/utils.js
Outdated
Comment on lines
2
to
4
| * utils 폴더입니다. | ||
| * 추후에 이 파일은 삭제해도 됩니다. | ||
| */ |
There was a problem hiding this comment.
utils는 주로 함수와 관련된 폴더라서 아래 mock 데이터와 연관은 없습니다!
어차피 기능 구현하다보면 삭제할 내용이지만 mock 데이터는 json 확장자를 사용하여 저장합니다!
| return ( | ||
| <div className={styles.container}> | ||
| <div className={styles.header}> | ||
| <h1>이달의 차트</h1> |
There was a problem hiding this comment.
h1 태그보다는 h2 태그가 더 좋을 것 같아요!
작은 기능 단위로 만들고 메인에 합쳐야 충돌이 덜 나기때문에 합쳐야 합니다! +) UI가 약간 깨집니다! 사진 상으로 판별이 좀 어렵긴한데..
|
|
🎉 구현한 기능 Preview: https://fandom-6nya29447-easyhyun00s-projects.vercel.app |
easyhyun00
added a commit
to easyhyun00/fandom-k
that referenced
this pull request
May 8, 2024
* ✨ Feat: 차트 기본골격 * ✨ Feat: 숫자에 콤마 찍기 * ✨ Feat: Profile 컴포넌트 적용 * ✨ Feat: 마지막 줄 밑줄 삭제 * ✨ Feat: 데스크톱 버전 완성 버튼 디자인 빼고 * 🔨 Refector: 임시 데이터 분리 * ✨ Feat: 반응형 구현 * 🐛 Fix: 데스크톱 반응형 줄어들게 * ✨ Feat: CustonButton 컴포넌트 적용 * ✨ Feat: 반응형 아이템 갯수 hook * ✨ Feat: 히스트 페이지 적용 * 🐛 Fix: 지현님 피드백 적용
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧩 이슈 번호
✅ 작업 사항
👩💻 공유 포인트 및 논의 사항