✨ Feat: NotFound 페이지 구현 #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 구현한 기능 Preview: https://fandom-2k8300sby-easyhyun00s-projects.vercel.app |
|
🎉 구현한 기능 Preview: https://fandom-fu5p7pe02-easyhyun00s-projects.vercel.app |
Bersk3r
approved these changes
May 9, 2024
JayChae
approved these changes
May 10, 2024
| <img src={randomImage} alt="아이돌 이미지" /> | ||
| <div /> | ||
| <Logo width={240} height={50} /> | ||
| </div> |
There was a problem hiding this comment.
오 이렇게 중간에 <div /> 넣어줘서 하는 거군요. ㅇㅎㅇㅎ
| width: 365px; | ||
| height: 365px; | ||
|
|
||
| background: radial-gradient( |
There was a problem hiding this comment.
이런 거는 어떻게 작성하는 거죠... 뭐 꿀팁 있나요. 계산하는 사이트라던지 ㅎㅎ
There was a problem hiding this comment.
피그마에서 복사하기 누른거예요ㅋㅋㅋ
| @@ -24,7 +25,7 @@ const router = createBrowserRouter([ | |||
| }, | |||
| { | |||
|
|
||
| const idolList = [Idol1, Idol2, Idol3, Idol4]; | ||
|
|
||
| const getRandomImage = () => { |
There was a problem hiding this comment.
랜덤으로 이미지 생성하셨네요 진짜 좋은 것 같습니다
easyhyun00
added a commit
to easyhyun00/fandom-k
that referenced
this pull request
May 10, 2024
* ✨ Feat: 낫파운드 페이지 UI 구현 * ✨ Feat: 랜덤 이미지 구현 * ✨ Feat: 버튼 클릭 시 랜딩 페이지로 이동 * ✨ Feat: 반응형 디자인 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧩 이슈 번호
✅ 작업 사항
notFound 페이지를 구현했습니다. 이상한 경로로 가면 뜹니다
새로고침 하면 이미지가 랜덤으로 바뀝니다. (총 4가지 있음 원하면 사진 넣어도 됨(정사각형 권장))
랜딩 페이지로 버튼을 누르면 랜딩페이지('/') 로 이동합니다.
👩💻 공유 포인트 및 논의 사항
디자인 수정 원하는 부분 있으면 말씀해주세요!