Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Feat: 그라디언트 컴포넌트 UI 생성 #56

Merged
merged 10 commits into from
May 15, 2024
Merged

✨ Feat: 그라디언트 컴포넌트 UI 생성 #56

merged 10 commits into from
May 15, 2024

Conversation

Bersk3r
Copy link
Contributor

@Bersk3r Bersk3r commented May 10, 2024 •
edited
Loading

🧩 이슈 번호 #53

✅ 작업 사항

전체 페이지 내 공통으로 사용하는 배경 컴포넌트 UI인 그라디언트 컴포넌트 UI 생성
image

TestPage에 적용되어 있습니다.

👩‍💻 공유 포인트 및 논의 사항

추후에 디자인적인 변경이 필요한 경우, 코멘트를 통해 수정을 진행하도록 하거나 팀 내에서 처리하도록 하겠습니다.

@github-actions GitHub Actions
Copy link

🎉 구현한 기능 Preview: https://fandom-1b1exxobp-easyhyun00s-projects.vercel.app

@Bersk3r Bersk3r self-assigned this May 10, 2024
@Bersk3r Bersk3r added the ✨ Feat 기능 개발 label May 10, 2024
easyhyun00
easyhyun00 approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@easyhyun00 easyhyun00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~

src/components/GradientWrapper/index.jsx Outdated
import Gradient from '@/assets/icons/Gradient';
import style from './styles.module.scss';

export const GradientWrapper = ({ children }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이름 그냥 Wrapper 로 해도 될 거 같아요..그냥.. 그라데이션이 잘 안보여서요..ㅋㅋㅋㅋㅋㅋ

src/components/GradientWrapper/styles.module.scss Outdated
}

.wrapper {
position: absolute;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

position: fixed 는 어떤가요?? 이렇게 하라는게 아니라 사실 저도 잘 모르겠네요..

src/components/GradientWrapper/styles.module.scss Outdated
Comment on lines 2 to 3
position: relative;
min-height: 100dvh;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

백그라운드 컬러도 넣어주세요!

JayChae
JayChae approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@JayChae JayChae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다! 지현님 피드백 반영하면 될 것 같습니다

App.js 파일 아래처럼 바꾸는 건 어떨까요?

js
return (
    <wrapper>
      <Header />
        <Outlet />
      </>
    </wrapper>
  );

@github-actions GitHub Actions
Copy link

🎉 구현한 기능 Preview: https://fandom-osgdvguu1-easyhyun00s-projects.vercel.app

@github-actions GitHub Actions
Copy link

🎉 구현한 기능 Preview: https://fandom-2e7h1o6j7-easyhyun00s-projects.vercel.app

@github-actions GitHub Actions
Copy link

🎉 구현한 기능 Preview: https://fandom-h6wu6oz7s-easyhyun00s-projects.vercel.app

@github-actions GitHub Actions
Copy link

🎉 구현한 기능 Preview: https://fandom-fmxmxql0c-easyhyun00s-projects.vercel.app

easyhyun00
easyhyun00 reviewed May 15, 2024
View reviewed changes
src/App.jsx
Comment on lines +8 to +9
const location = useLocation();
const regxr = /(\/list|\/myPage)/;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정규식 말고 연산자를 사용해서 구현해보세요

@github-actions GitHub Actions
Copy link

🎉 구현한 기능 Preview: https://fandom-3b8pqx4b9-easyhyun00s-projects.vercel.app

@github-actions GitHub Actions
Copy link

🎉 구현한 기능 Preview: https://fandom-o4sno76t5-easyhyun00s-projects.vercel.app

@Bersk3r Bersk3r merged commit 75bb3f2 into main May 15, 2024
1 check passed
@Bersk3r Bersk3r deleted the feat-53-gradient branch May 15, 2024 11:27
easyhyun00 added a commit to easyhyun00/fandom-k that referenced this pull request May 15, 2024
@easyhyun00
✨ Feat: 그라디언트 컴포넌트 UI 생성 (sprint6-part2#56)
20e5867 
* ✨ Feat: 그라디언트 컴포넌트 UI 생성

* ♻️ Refactor: 랩퍼 컴포넌트 구조 개선

* ♻️ Refactor: Landing 및 Not Found 페이지 그라데이션 적용

* 📦️ Chore: 임시 내용 저장

* 🐛 Fix: 공통 컴포넌트 적용 완료

* 📦️ Chore: Background 컴포넌트 일부 적용 및 특정 페이지 내 scss 파일 변경
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easyhyun00 easyhyun00 easyhyun00 approved these changes

@JayChae JayChae JayChae approved these changes

@nelryoS2 nelryoS2 Awaiting requested review from nelryoS2

@i-nooo-2 i-nooo-2 Awaiting requested review from i-nooo-2

Assignees

@Bersk3r Bersk3r

Labels
✨ Feat 기능 개발
Projects
프로젝트 관리
Status: 완료
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ Feat 그라데이션 공통 Wrapper 컴포넌트 UI 구현
3 participants
@Bersk3r @JayChae @easyhyun00