Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”จ Refactor: ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง #92

Merged
merged 6 commits into from
May 22, 2024
Merged

๐Ÿ”จ Refactor: ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง #92

merged 6 commits into from
May 22, 2024

Conversation

JayChae
Copy link
Contributor

@JayChae JayChae commented May 18, 2024

๐Ÿงฉ ์ด์Šˆ ๋ฒˆํ˜ธ

โœ… ์ž‘์—… ์‚ฌํ•ญ

  • ํด๋ž˜์Šค๋ช… ์นด๋ฉœ์ผ€์ด์Šค -> ์–ธ๋”๋ฐ”
  • ๋ถˆํ•„์š”ํ•œ ํด๋” ๋ฐ ํŒŒ์ผ ์‚ญ์ œ
  • ์ฝ”๋“œ ์ •๋ฆฌ ๋ฐ ๋ฆฌํŒฉํ† ๋ง

๐Ÿ‘ฉโ€๐Ÿ’ป ๊ณต์œ  ํฌ์ธํŠธ ๋ฐ ๋…ผ์˜ ์‚ฌํ•ญ

@JayChae JayChae added the ๐Ÿ”จ Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง label May 18, 2024
@JayChae JayChae self-assigned this May 18, 2024
@github-actions GitHub Actions
Copy link

๐ŸŽ‰ ๊ตฌํ˜„ํ•œ ๊ธฐ๋Šฅ Preview: https://fandom-mglxidnof-easyhyun00s-projects.vercel.app

easyhyun00
easyhyun00 approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@easyhyun00 easyhyun00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ตฟ

@github-actions GitHub Actions
Copy link

๐ŸŽ‰ ๊ตฌํ˜„ํ•œ ๊ธฐ๋Šฅ Preview: https://fandom-e5wimrz4h-easyhyun00s-projects.vercel.app

@github-actions GitHub Actions
Copy link

๐ŸŽ‰ ๊ตฌํ˜„ํ•œ ๊ธฐ๋Šฅ Preview: https://fandom-726sbjvk7-easyhyun00s-projects.vercel.app

@github-actions GitHub Actions
Copy link

๐ŸŽ‰ ๊ตฌํ˜„ํ•œ ๊ธฐ๋Šฅ Preview: https://fandom-r3x20tbkw-easyhyun00s-projects.vercel.app

@Bersk3r Bersk3r merged commit 6579017 into main May 22, 2024
1 check passed
@Bersk3r Bersk3r deleted the feat-87 branch May 22, 2024 02:09
easyhyun00 added a commit to easyhyun00/fandom-k that referenced this pull request May 22, 2024
@easyhyun00 @Bersk3r
๐Ÿ”จ Refactor: ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง (sprint6-part2#92)
8b9ab11 
* ๐Ÿ”จ Refector: ํด๋ž˜์Šค๋ช… ์ˆ˜์ • +  ์ฝ”๋“œ ๊ฐœ์„ 

* ๐Ÿ”จย Refactor: toastContainer app.jsx ๋กœ ์ด๋™

* ๐Ÿ”จย Refactor: ํ‘ธํ„ฐ ๋งํฌ ํด๋ฆญ ์ด๋ฒคํŠธ div ๋กœ ์ด๋™

* โœ๏ธ Fix: ๋งˆ์ดํŽ˜์ด์ง€ ๊ด€๋ จ ์ปดํฌ๋„ŒํŠธ ๋‚ด JSDocs ์ •๋ณด ์ž‘์„ฑ ๋ฐ ์˜คํƒ€ ์ˆ˜์ •

---------

Co-authored-by: Bersk3r <[email protected]>
Co-authored-by: easyhyun00 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easyhyun00 easyhyun00 easyhyun00 approved these changes

@Bersk3r Bersk3r Awaiting requested review from Bersk3r

@nelryoS2 nelryoS2 Awaiting requested review from nelryoS2

@i-nooo-2 i-nooo-2 Awaiting requested review from i-nooo-2

Assignees

@JayChae JayChae

Labels
๐Ÿ”จ Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

๐Ÿ› Fix: ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง
3 participants
@JayChae @easyhyun00 @Bersk3r