Address a few bugs in IsoMdlPresentation and modify MDoc (#44)

* Remove unused argument from MDoc init and make IsoMdlPresentation init public * Modify query to retrieve signing key from KeyStore * Rename MDoc init argument * Have consumer pass signing key into submitNamespaces
spruceid · Oct 23, 2024 · 8824cb9 · 8824cb9
1 parent 98cb2bb
commit 8824cb9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 30 deletions.
diff --git a/Sources/MobileSdk/IsoMdlPresentation.swift b/Sources/MobileSdk/IsoMdlPresentation.swift
@@ -19,7 +19,7 @@ public class IsoMdlPresentation {
     var bleManager: MDocHolderBLECentral!
     var useL2CAP: Bool
 
-    init?(
+    public init?(
         mdoc: MDoc, engagement: DeviceEngagement,
         callback: BLESessionStateDelegate, useL2CAP: Bool
     ) {
@@ -49,38 +49,14 @@ public class IsoMdlPresentation {
         bleManager.disconnectFromDevice(session: self.session)
     }
 
-    public func submitNamespaces(items: [String: [String: [String]]]) {
+    public func submitNamespaces(items: [String: [String: [String]]], signingKey: SecKey) {
         do {
             let payload = try session.generateResponse(permittedItems: items)
-            let query =
-                [
-                    kSecClass: kSecClassKey,
-                    kSecAttrApplicationLabel: self.mdoc.keyAlias,
-                    kSecReturnRef: true
-                ] as [String: Any]
 
-            // Find and cast the result as a SecKey instance.
-            var item: CFTypeRef?
-            var secKey: SecKey
-            switch SecItemCopyMatching(query as CFDictionary, &item) {
-            case errSecSuccess:
-                // swiftlint:disable force_cast
-                secKey = item as! SecKey
-            // swiftlint:enable force_cast
-            case errSecItemNotFound:
-                self.callback.update(state: .error(.generic("Key not found")))
-                self.cancel()
-                return
-            case let status:
-                self.callback.update(
-                    state: .error(.generic("Keychain read failed: \(status)")))
-                self.cancel()
-                return
-            }
             var error: Unmanaged<CFError>?
             guard
                 let derSignature = SecKeyCreateSignature(
-                    secKey,
+                    signingKey,
                     .ecdsaSignatureMessageX962SHA256,
                     payload as CFData,
                     &error) as Data?

diff --git a/Sources/MobileSdk/MDoc.swift b/Sources/MobileSdk/MDoc.swift
@@ -15,13 +15,12 @@ public class MDoc: Credential {
   /// IssuerSignedItemBytes will be bytes, but its composition is defined here
   /// https://github.com/spruceid/isomdl/blob/f7b05dfa/src/definitions/issuer_signed.rs#L18
   public init?(
-    fromMDoc issuerAuth: Data, namespaces: [MDocNamespace: [IssuerSignedItemBytes]],
-    keyAlias: String
+    fromMDoc mdocBytes: Data, keyAlias: String
   ) {
     self.keyAlias = keyAlias
     do {
       try self.inner = SpruceIDMobileSdkRs.Mdoc.fromCborEncodedDocument(
-        cborEncodedDocument: issuerAuth, keyAlias: keyAlias)
+        cborEncodedDocument: mdocBytes, keyAlias: keyAlias)
     } catch {
       print("\(error)")
       return nil