Camv 528 port key manager to sprucekit sdk swift #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jszersze
commented
Jun 6, 2024
project.yml
Outdated
| @@ -4,7 +4,7 @@ options: | |||
| packages: | |||
| SpruceIDWalletSdkRs: | |||
| url: https://github.com/spruceid/wallet-sdk-rs | |||
| from: 0.0.4 | |||
| from: 0.0.25 | |||
There was a problem hiding this comment.
Not sure if this change is needed. If this is from as in ^0.0.4 then probably not.
jszersze
commented
Jun 6, 2024
| @@ -57,6 +57,7 @@ extension UIScreen { | |||
| static let screenSize = UIScreen.main.bounds.size | |||
| } | |||
|
|
|||
| @available(iOS 14.0, *) | |||
There was a problem hiding this comment.
I had to add this, otherwise I had trouble building.
jszersze
commented
Jun 6, 2024
Package.swift
Outdated
| @@ -6,7 +6,8 @@ import PackageDescription | |||
| let package = Package( | |||
| name: "SpruceIDWalletSdk", | |||
| platforms: [ | |||
| .iOS(.v14) | |||
| .iOS(.v13), | |||
| .macOS(.v10_15) | |||
There was a problem hiding this comment.
Rust would need to produce an artifact for macOS, perhaps this should be removed until it does.
CharlesShuller
approved these changes
Jun 7, 2024
todd-spruceid
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the KeyManager for generating secret keys in the Secure Enclave.