OID4VCI Integration #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbihel
reviewed
Aug 23, 2024
Sources/MobileSdk/OID4VCI.swift
Outdated
| vm: String, | ||
| publicJwk: String, | ||
| durationInSecs: Int64? | ||
| ) throws -> [UInt8] { |
There was a problem hiding this comment.
From what I know it's better to use Data instead of raw arrays of bytes
sbihel
approved these changes
Sep 4, 2024
Signed-off-by: Tiago Nascimento <[email protected]>
Signed-off-by: Tiago Nascimento <[email protected]>
Signed-off-by: Tiago Nascimento <[email protected]>
Signed-off-by: Tiago Nascimento <[email protected]>
theosirian
force-pushed
the
skit-457-integrate-oid4vci-into-sprucekit
branch
from
41a2614 to
b0f5c02
Compare
Signed-off-by: Tiago Nascimento <[email protected]>
theosirian
force-pushed
the
skit-457-integrate-oid4vci-into-sprucekit
branch
from
daaa245 to
7234d13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on spruceid/mobile-sdk-rs#29.