Improve submission validation and input extraction. #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the presentation submission validation in two ways:
PresentationSubmission::find_inputs
function to find and extract the inputs. It returns aMatchingInputs
structure containing all the inputs that matched the presentation definition.ClaimsDecoder
trait that is given to thefind_inputs
to decode the visited input claims. I provided a "default" implementationNoClaimsDecoder
that doesn't decode anything (so it behaves exactly like the current implementation).For the validation part:
MatchingInput::validate
to validate the extracted input against the presentation definition requirements.PresentationSubmission::find_and_validate_inputs
that just callsfind_inputs
andvalidate
.Other changes
I've set some fields public and removed some accessors.