return application json encoded authorization response #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Tate <[email protected]>
Ryanmtate
force-pushed
the
fix/update-authorization-response-encoding
branch
2 times, most recently
from
2509f66
to
f4c18a0
Compare
Signed-off-by: Ryan Tate <[email protected]>
Ryanmtate
force-pushed
the
fix/update-authorization-response-encoding
branch
from
f4c18a0
to
cf66d93
Compare
timothee-haudebourg
approved these changes
Oct 31, 2024
| "failed to encode presentation_submission as 'application/x-www-form-urlencoded'", | ||
| )?; | ||
|
|
||
| Ok(encoded) |
There was a problem hiding this comment.
It works so I'm not going to block it but:
- there is no reason for the serialization to fail, so you can safely
unwrapinstead of returning aResult - you could use a custom
structinstead of aHashMapto avoid memory allocations.
There was a problem hiding this comment.
commit ad3974c removes the hash map and uses a custom struct here instead.
Signed-off-by: Ryan Tate <[email protected]>
…r values Signed-off-by: Ryan Tate <[email protected]>
Juliano1612
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.