Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove animation parameter, switch to using animated on UICollectionView directly. Add onDidEndDeceleration #552

Merged
merged 8 commits into from
Jan 16, 2025
Merged

Remove animation parameter, switch to using animated on UICollectionView directly. Add onDidEndDeceleration #552

merged 8 commits into from
Jan 16, 2025

Conversation

maxg-square
Copy link
Contributor

Animating in a UIView animation block causes artifacts when scrolling. Remove animation blocks, and replace with simple animated parameter. Also introduce onDidEndDeceleration.

Checklist

Please do the following before merging:

  • Ensure any public-facing changes are reflected in the changelog. Include them in the Main section.

kyleve and others added 4 commits October 19, 2024 07:09
@kyleve
Remove animation parameter, switch to using animated on UICollectionV…
c99999d 
…iew directly. Animating in a UIView animation block causes artifacts when scrolling.
@maxg-square
Merge branch 'main' into kve/move-to-animated
0a1dc2a 
* main:
  release: Prepare 14.5.0 release (#551)
  fix: Move CacheClearer files to proper locations (#550)
  feat: Introduce CacheClearer to force-clear static caches (#549)
  Bump CI Xcode to 15.4 (from 15.1)
  bumping version to 14.4.1
  bumping blueprint
@maxg-square
Add onDidEndDeceleration and switch callback to be triggered by that.
d6e69e6
@maxg-square
Fix pin too
22b76ff
@maxg-square maxg-square changed the title Maxg/move to animated Remove animation parameter, switch to using animated on UICollectionView directly. Add onDidEndDeceleration Jan 8, 2025
@maxg-square maxg-square mentioned this pull request Jan 8, 2025
Closed
1 task
@maxg-square maxg-square requested a review from kyleve January 9, 2025 23:02
@maxg-square maxg-square enabled auto-merge January 16, 2025 22:28
@maxg-square maxg-square merged commit 2086992 into main Jan 16, 2025
4 checks passed
@maxg-square maxg-square deleted the maxg/move-to-animated branch January 16, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyleve kyleve kyleve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxg-square @kyleve