Kotlin & KSP 2.1.10 #2029
Merged
Kotlin & KSP 2.1.10 #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Egorand
commented
Nov 27, 2024
| @@ -202,7 +202,7 @@ public class AnnotationSpec private constructor( | |||
| @Suppress("PLATFORM_CLASS_MAPPED_TO_KOTLIN") | |||
| val javaAnnotation = annotation as java.lang.annotation.Annotation | |||
| val builder = builder(javaAnnotation.annotationType()) | |||
| .tag(annotation) | |||
| .tag<Annotation>(annotation) | |||
There was a problem hiding this comment.
Fixes the following warning:
e: warnings found and -Werror specified
w: file:///Users/egor/Development/block-workspace/kotlinpoet/kotlinpoet/src/jvmMain/kotlin/com/squareup/kotlinpoet/AnnotationSpec.kt:205:12
Type argument for reified type parameter 'T' was inferred to the intersection
of ['java.lang.annotation.Annotation' & 'kotlin.Annotation'].
Reification of an intersection type results in the common supertype being used.
This may lead to subtle issues and an explicit type argument is encouraged.
This will become an error in a future release.
|
@ZacSweers there's a bunch of I discovered that if I simply comment out the |
Egorand
commented
Nov 28, 2024
| public fun <T : Alias41<Alias23, out Alias77<Alias73<Int>>>> bar(vararg arg1: T): Unit = TODO() | ||
| } | ||
| public class TestTransitiveAliases { | ||
| public fun <T : Alias41<Alias43<Alias23>, Alias47<out Alias77<Alias73<Int>>>>> bar(vararg arg1: T): Unit = TODO() |
There was a problem hiding this comment.
Not sure why this started behaving differently with KSP. @ZacSweers any thoughts?
This was referenced Nov 28, 2024
Closed
Closed
Closed
|
I'll look after vacation! |
This was referenced Dec 4, 2024
Closed
Closed
KSP 2.1.0-1.0.29 kct 0.7.0
Egorand
force-pushed
the
egor.241127.kotlin-2.1.0
branch
from
370c17e to
073df16
Compare
Egorand
force-pushed
the
egor.241127.kotlin-2.1.0
branch
from
b276780 to
30ee3e4
Compare
Egorand
force-pushed
the
egor.241127.kotlin-2.1.0
branch
from
30ee3e4 to
08e7639
Compare
Egorand
commented
Feb 14, 2025
Comment on lines
+52
to
+59
| @Before | ||
| fun skipOnJdk8() { | ||
| val javaVersion = System.getProperty("java.version") ?: return // Don't skip if version unknown. | ||
| assumeFalse( | ||
| "These tests currently fail on JDK 8 when useKsp2 == false", | ||
| javaVersion.startsWith("1.8") && !useKsp2, | ||
| ) | ||
| } |
There was a problem hiding this comment.
Turning off these tests for now as they fail with an "internal error". Seems okay since it's just on JDK 8.
JakeWharton
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.