[4.x] Avoid exposing internal functions and properties #8137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something like |
Goooler
force-pushed
the
internal-extension-backport
branch
from
76a13d3 to
1fd8849
Compare
This is a backport for 4.x branch from f408411.
Goooler
force-pushed
the
internal-extension-backport
branch
from
45438ef to
bc7ebb5
Compare
Goooler
changed the title
yschimke
approved these changes
Dec 19, 2023
|
@Goooler thanks for the fix. Not sure when it will be out, but it's a good idea to backport. |
|
This is good, but why backport an internal refactoring to 4.x? This doesn’t give us any maintainability benefits but it does make accepting a 4.x upgrade more difficult? |
swankjesse
pushed a commit
that referenced
this pull request
Apr 1, 2024
This reverts commit 710bdc1.
|
As I see something like |
|
That kind of issue is super annoying, and I’m grateful that Kotlin introduced the |
|
Makes sense! |
swankjesse
pushed a commit
that referenced
this pull request
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport for 4.x branch from #7734.