This repository has been archived by the owner on Apr 30, 2019. It is now read-only.
Checking for inherited Subscribe/Produce annotated methods #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a reasonable approach. And it's probably time to add it now that no one is supporting pre-4.0 (and if they are they can deal with the extra few nanos or simply not upgrade). |
| } | ||
|
|
||
| PRODUCERS_CACHE.put(listenerClass, producerMethods); | ||
| SUBSCRIBERS_CACHE.put(listenerClass, subscriberMethods); | ||
| } | ||
|
|
||
| static boolean shouldCheck(Class<?> clazz) { | ||
| String name = clazz.getName(); | ||
| return !name.startsWith("java") && !name.startsWith("android"); |
There was a problem hiding this comment.
You need the "." otherwise "javasucks.Class" and "androidsucks.Class" names will incorrectly return true.
aheuermann
force-pushed
the
inherited_methods
branch
2 times, most recently
from
84733f4
to
d0b816f
Compare
aheuermann
force-pushed
the
inherited_methods
branch
from
d0b816f
to
225d659
Compare
|
Updated. Let me know if this is closer to what you had in mind. |
This was referenced Jan 8, 2015
|
Hi, is there any news about this feature? It would be really useful to have it in production :) (thanks aheuermann) |
|
@JakeWharton any chance this will get merged soon? This would be a really useful feature. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into the issue discussed in #109 & #26 today. I was able to workaround it by registering a separate event listener class, but it didn't seem ideal. Let me know what you think about this approach.
Thanks for the great library!