This repository has been archived by the owner on Apr 30, 2019. It is now read-only.
Website copyedit #82
Open
Website copyedit #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| subscribers have been called.</p> | ||
| <p>The bus calls every method that subscribes to events of the argument's type, passing along the | ||
| argument itself. Note that this is a synchronous action—when program execution continues, it's | ||
| guaranteed that all subscribing methods have been called.</p> |
There was a problem hiding this comment.
We need to add a note here before I forget. Something like:
Note: If you post an event from within a subscribe method the events will not be delivered synchronously. They will be enqueued for after the current event event's delivery has completed.
| subscribers have been called.</p> | ||
| <p>The bus calls every method that subscribes to events of the argument's type, passing along the | ||
| argument itself. In most cases, this is a synchronous action—when program execution continues, it's | ||
| guaranteed that all subscribing methods have been called. This is <em>not</em> a synchronous |
There was a problem hiding this comment.
@JakeWharton I added language explaining non-synchronous situations. Am I correct in that post isn't synchronous if it's called during the execution of any other bus method, or is it just during another post()?
There was a problem hiding this comment.
I will have to double-check today. But I think you are correct in that it happens for all methods.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review to ensure technical accuracy is maintained. Thanks!