Skip to content

Commit

Permalink
Merge pull request #543 from srl-labs/txoffload
Browse files Browse the repository at this point in the history
fixed disabling checksum offload for linux nodes and `tools disable-tx-offload` command
  • Loading branch information
hellt authored Jul 23, 2021
2 parents 87afca0 + b86589c commit 5863675
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
2 changes: 1 addition & 1 deletion cmd/disableTxOffload.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ var disableTxOffloadCmd = &cobra.Command{

log.Infof("getting container '%s' information", cntName)

nodeRuntime, err := c.GetNodeRuntime(cntName)
nodeRuntime := c.GlobalRuntime()
if err != nil {
return err
}
Expand Down
4 changes: 4 additions & 0 deletions docs/rn/0.15.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ With that in mind we launched the containerlab's own [discord server](https://di
* Allow ceos startup config to receive ipv4/6 addresses [#528](https://github.com/srl-labs/containerlab/issues/528)
* Added JSON-RPC server to SR Linux default configuration

### 0.15.4
* Fixed disabling tx checksum offload for linux nodes [#543](https://github.com/srl-labs/containerlab/issues/543)
* Fixed `tools disable-tx-offload` command [#543](https://github.com/srl-labs/containerlab/issues/543)

[^1]: as opposed to a VM-way by running Cumulus with [vrnetlab](../manual/vrnetlab.md)
[^2]: both with `ignite` runtime or `docker` runtime
[^3]: starting with SR Linux 21.3, the license file is optional
2 changes: 1 addition & 1 deletion nodes/linux/linux.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ func (l *linux) Deploy(ctx context.Context) error {

func (l *linux) PostDeploy(ctx context.Context, ns map[string]nodes.Node) error {
log.Debugf("Running postdeploy actions for Linux '%s' node", l.cfg.ShortName)
return nil
return types.DisableTxOffload(l.cfg)
}

func (s *linux) GetImages() map[string]string {
Expand Down
2 changes: 1 addition & 1 deletion types/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ func DisableTxOffload(n *NodeConfig) error {
return err
}
err = nodeNS.Do(func(_ ns.NetNS) error {
// disabling offload on lo0 interface
// disabling offload on eth0 interface
err := utils.EthtoolTXOff("eth0")
if err != nil {
log.Infof("Failed to disable TX checksum offload for 'eth0' interface for Linux '%s' node: %v", n.ShortName, err)
Expand Down

0 comments on commit 5863675

Please sign in to comment.