Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove publish ports section #2404

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Remove publish ports section #2404

merged 2 commits into from
Jan 17, 2025

Conversation

hellt
Copy link
Member

@hellt hellt commented Jan 17, 2025

port publishing was not working for a long time, until we find an alternative it makes no sense in keeping it

@hellt hellt merged commit afc759e into main Jan 17, 2025
60 of 61 checks passed
@hellt hellt deleted the remove-publish branch January 17, 2025 09:53
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.50%. Comparing base (3f31afd) to head (c1d6f07).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2404      +/-   ##
==========================================
+ Coverage   51.97%   52.50%   +0.53%     
==========================================
  Files         172      168       -4     
  Lines       17394    16912     -482     
==========================================
- Hits         9040     8880     -160     
+ Misses       7412     7120     -292     
+ Partials      942      912      -30     
Files with missing lines Coverage Δ
clab/config.go 68.09% <ø> (-0.07%) ⬇️
clab/register.go 100.00% <ø> (ø)
types/node_definition.go 95.00% <ø> (-0.11%) ⬇️
types/topology.go 69.54% <ø> (+0.85%) ⬆️
types/types.go 62.88% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant