Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iptables rules for mgmt net and bridges in both directions #2406

Merged
merged 14 commits into from
Jan 17, 2025

Conversation

hellt
Copy link
Member

@hellt hellt commented Jan 17, 2025

setting up the rules in one of the directions (in/out) was not enough for all use cases. This fix sets the rules in both in and out directions for mgmt network and bridges used in the topology

@hellt hellt changed the title fix iptables command direction flag iptables rules for mgmt net and bridges in both directions Jan 17, 2025
@hellt hellt merged commit 3e7a7c3 into main Jan 17, 2025
61 checks passed
@hellt hellt deleted the iptables-fixups-after-0.62 branch January 17, 2025 23:57
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 76.92308% with 42 lines in your changes missing coverage. Please review.

Project coverage is 52.76%. Comparing base (d7588f9) to head (a8a9e2b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
runtime/docker/firewall/iptables/client.go 0.00% 30 Missing ⚠️
runtime/docker/firewall.go 88.88% 4 Missing and 2 partials ⚠️
nodes/bridge/bridge.go 86.36% 2 Missing and 1 partial ⚠️
runtime/docker/firewall/nftables/client.go 95.71% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2406      +/-   ##
==========================================
+ Coverage   52.51%   52.76%   +0.25%     
==========================================
  Files         168      168              
  Lines       16940    17039      +99     
==========================================
+ Hits         8896     8991      +95     
- Misses       7128     7132       +4     
  Partials      916      916              
Files with missing lines Coverage Δ
runtime/docker/firewall/nftables/rule.go 82.45% <100.00%> (-0.60%) ⬇️
nodes/bridge/bridge.go 70.32% <86.36%> (+4.61%) ⬆️
runtime/docker/firewall/nftables/client.go 79.35% <95.71%> (+2.94%) ⬆️
runtime/docker/firewall.go 70.88% <88.88%> (+33.84%) ⬆️
runtime/docker/firewall/iptables/client.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant