Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Command: Source the proxy address from env var #2507

Merged
merged 3 commits into from
Mar 7, 2025
Merged

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented Mar 6, 2025

implementing #2505

@steiler
Copy link
Collaborator Author

steiler commented Mar 6, 2025

@toweber can you try this out, please?

@steiler steiler changed the title source the proxy address from environment variables Upgrade Command: Source the proxy address from env var Mar 6, 2025
@toweber
Copy link
Contributor

toweber commented Mar 7, 2025

Looks good from my end now

@hellt hellt merged commit 520d934 into main Mar 7, 2025
66 of 67 checks passed
@hellt hellt deleted the upgradeviaProxy branch March 7, 2025 08:56
@hellt
Copy link
Member

hellt commented Mar 7, 2025

thanks!

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 52.20%. Comparing base (b789b6a) to head (5e36308).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
cmd/version/upgrade.go 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2507      +/-   ##
==========================================
- Coverage   52.22%   52.20%   -0.03%     
==========================================
  Files         173      173              
  Lines       17862    17869       +7     
==========================================
  Hits         9328     9328              
- Misses       7546     7553       +7     
  Partials      988      988              
Files with missing lines Coverage Δ
cmd/version/upgrade.go 4.44% <0.00%> (-0.82%) ⬇️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants