Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom SR Linux topology file via binds #2509

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Conversation

hellt
Copy link
Member

@hellt hellt commented Mar 7, 2025

Allows a user to bind mount a custom topology file and not conflict with the default topology file.

fix #2506

@hellt hellt merged commit fcfc20b into main Mar 7, 2025
67 checks passed
@hellt hellt deleted the custom-srl-topology-file branch March 7, 2025 09:59
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 76.92308% with 24 lines in your changes missing coverage. Please review.

Project coverage is 52.20%. Comparing base (520d934) to head (bcedfe8).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
nodes/srl/srl.go 74.73% 15 Missing and 9 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2509   +/-   ##
=======================================
  Coverage   52.20%   52.20%           
=======================================
  Files         173      173           
  Lines       17869    17882   +13     
=======================================
+ Hits         9328     9335    +7     
- Misses       7553     7559    +6     
  Partials      988      988           
Files with missing lines Coverage Δ
utils/containers.go 65.38% <100.00%> (+7.24%) ⬆️
nodes/srl/srl.go 58.34% <74.73%> (+0.30%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow a user to provide SR Linux topology yaml file with custom platform definition
1 participant