Upstream fetch

[PhantornRU]

About the pull request

Подтягиваем изменения

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
code: upstream fetch
/:cl:

Summary by Sourcery

Update security records console to use TGUI, add chat reliability layer and make various bug fixes.

New Features:

• Implement a chat reliability layer to ensure message delivery.

Tests:

• Add unit tests for areas needing power.

[sourcery-ai]

Reviewer's Guide by Sourcery

This upstream fetch PR integrates a diverse set of changes pulled in from upstream. Major modifications include a completely overhauled TGUI-based security records interface; a refactor and expansion of USCM CO equipment presets—including a new goon medic preset and multiple career-path variants; the introduction of a chat reliability layer with sequence tracking and resend logic; standardized explosion and shrapnel parameter naming; widespread adjustments to power requirement flags on areas and machinery; and a host of minor bugfixes and cosmetic improvements.

Class Diagram for USCM CO Equipment Presets with Career Path Variants

classDiagram
    class USCM_CO {
      +gear_preset
      +gear_preset_whitelist : map
      +check_career_path(client)
    }
    class USCM_CO_Infantry {
      +preset : EquipmentPreset
    }
    class USCM_CO_Intel {
      +preset : EquipmentPreset
    }
    class USCM_CO_Medical {
      +preset : EquipmentPreset
    }
    class USCM_CO_Aviation {
      +preset : EquipmentPreset
    }
    class USCM_CO_Tanker {
      +preset : EquipmentPreset
    }
    class USCM_CO_Engineering {
      +preset : EquipmentPreset
    }
    class USCM_CO_Logistics {
      +preset : EquipmentPreset
    }

    USCM_CO <|-- USCM_CO_Infantry
    USCM_CO <|-- USCM_CO_Intel
    USCM_CO <|-- USCM_CO_Medical
    USCM_CO <|-- USCM_CO_Aviation
    USCM_CO <|-- USCM_CO_Tanker
    USCM_CO <|-- USCM_CO_Engineering
    USCM_CO <|-- USCM_CO_Logistics

Loading

File-Level Changes

Change	Details	Files
Security Records Interface Refactor and TGUI implementation	Added a new TGUI panel (SecurityRecords.jsx) to display and interact with security records data including personal, medical, and security fields. Introduced functionality for updating photos, editing record fields, adding/deleting comments, and printing records from the UI. Added a corresponding SCSS file to style the new security records interface. Modified supporting backend code to package records data, pass scanner fingerprint data, and update UI via TGUI.	tgui/packages/tgui/interfaces/SecurityRecords.jsx tgui/packages/tgui/styles/interfaces/SecurityRecords.scss code/controllers/subsystem/chat.dm code/datums/chat_payload.dm
USCM Commanding Officer Equipment Preset Redesign	Introduced a new equipment preset file (uscm_co.dm) that consolidates and refactors CO loadouts. Added multiple career-path variants (Infantry, Intel, Medical, Aviation, Tanker, Engineering, Logistics), each with council and leader (plus) sub-variants. Included new uniform configurations for goon medics, technicians and leaders. Updated client preferences to allow selection of a command career path.	code/modules/gear_presets/uscm_co.dm code/modules/client/preferences.dm
Chat Reliability Layer Integration	Implemented sequence numbering for chat payloads and stored message history per client. Added logic to handle message resends when sequence discrepancies are detected. Updated the chat subsystem (both server and TGUI backend) to use the new chat payload model and send immediate payloads with reliability checks.	code/controllers/subsystem/chat.dm code/datums/chat_payload.dm tgui/packages/tgui/backend.ts code/__DEFINES/chat.dm
Explosion and Shrapnel Mechanics Updates	Renamed and standardized 'angle' parameters to 'shrapnel_spread' and added an optional 'hit_angle' parameter for explosive objects. Updated explosion-related procedures and calls such as create_shrapnel to use the new parameter names. Modified explosive item definitions in several files (explosive.dm, mine.dm, plastic.dm, warhead.dm, rocket.dm) for consistent behavior.	code/game/objects/explosives/explosive.dm code/game/objects/explosives/mine.dm code/objects/shrapnel.dm code/datums/ammo/rocket.dm code/modules/reagents/Chemistry-Holder.dm
Area and Machinery Power Requirement Adjustments	Updated numerous area definitions to set 'requires_power' (or similar flags) to FALSE instead of numeric 0. Adjusted machinery and structural objects (APCs, cameras, constructable frames, IV drips, storm sirens, etc.) to include explicit 'needs_power = FALSE' when appropriate. Ensured that areas with 'always_unpowered' or 'unlimited_power' are correctly excluded from standard power checks.	code/game/area/BigRed/BigRed.dm code/game/area/Corsat.dm code/game/area/LV522_Chances_Claim.dm code/modules/power/apc.dm code/game/machinery/computer/hybrisa_slotmachine.dm code/game/machinery/constructable_frame.dm
Miscellaneous Bugfixes and Cosmetic Improvements	Adjusted paper templates and changelog entries to modify spacing and margin styles for improved readability. Fixed minor bugs such as signature formatting in 'all hands on deck' announcements and corrected sound frequency ranges for minor effects. Updated button styling (added cursor pointer) and other CSS fixes in Button.scss. Addressed various minor code cleanups and one-letter variable removals to improve readability and maintainability.	code/modules/paperwork/paper.dm tgui/packages/tgui/styles/components/Button.scss code/game/sound.dm code/__DEFINES/job.dm

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.