Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wounds and examine translate #98

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ROdenFL
Copy link

@ROdenFL ROdenFL commented Feb 11, 2025

About the pull request

Еще сильнее переводит и исправляет обследование хумана. Переводит атак хэнд в дружественном интенте ака проверку на раны.

Explain why it's good for the game

русский

Testing Photographs and Procedure

Да

Screenshots & Videos

{475E18BF-44DB-40BE-B856-224180DB02A6}

{CD43F856-1808-491A-80BB-91ACFD919E95}

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: перевод осмотра людей
/:cl:

Summary by Sourcery

Enhancements:

  • Improve the translation of human examination and wound descriptions to Russian, ensuring more accurate and contextually appropriate language.

Copy link

sourcery-ai bot commented Feb 11, 2025

Reviewer's Guide by Sourcery

This PR improves Russian localization for human examination and wound description. The changes primarily refactor pronoun handling in examine routines, update self-examination messages, and integrate external wound translation data to deliver more accurate Russian text for injury and limb status displays.

Flow diagram for Human Examination Localization (Flow Diagram)

flowchart TD
    A[Start Examine Process] --> B[Set pronouns using ru_p_they, ru_p_them, & ru_p_theirs]
    B --> C[Compose examine message with icon, rank, and clothing details]
    C --> D[Process limb and wound details]
    D --> E[Call ru_wounds_desc & ru_wounds_desc_list for localized wound descriptions]
    E --> F[Integrate wound and injury texts into message]
    F --> G[Display localized examine message to the user]
    G --> H[End Process]
Loading

Flow diagram for Wound Translations Initialization (Flow Diagram)

flowchart TD
    A[Start Translation Initialization] --> B[Determine wound translation file path]
    B --> C[Check if ru_wounds.toml exists]
    C --> D{File exists?}
    D -- Yes --> E[Read wound translations from ru_wounds.toml]
    E --> F[Populate GLOB.ru_wound_descs global list]
    F --> G[Enable ru_wounds_desc functionality]
    D -- No --> H[Skip wound translations load]
    G --> I[End Initialization]
    H --> I[End Initialization]
Loading

File-Level Changes

Change Details Files
Refactored gender pronoun handling in human examination messages
  • Introduced a new pronoun variable (t_theirs) to replace generic t_him usage.
  • Adjusted conditional logic for suit and mask checks to better handle translation nuances.
  • Updated several examine message strings to use the new pronoun and improved Russian phrasing.
code/modules/mob/living/carbon/human/examine.dm
Improved localized self-examination and injury messages
  • Modified messages in human_attackhand.dm to use fully Russian text for self-inspection and limb status.
  • Replaced English message templates with Russian equivalents for visible messages and limb damage descriptions.
code/modules/mob/living/carbon/human/human_attackhand.dm
Added wound translation support
  • Created a new translation data file (ru_wounds.toml) containing detailed wound descriptions.
  • Updated _translations.dm to load and incorporate wound translation data.
  • Introduced translation procedures in translate_wounds.dm to process wound descriptors.
modular/translations/_translations.dm
modular/translations/code/translation_data/ru_wounds.toml
modular/translations/code/translate_wounds.dm
modular/translations/_translations.dme
Minor adjustments in limb organ translations
  • Added a call to ru_names_rename for renaming Russian names in limbs.dm.
  • Updated the output for active limb surgeries to return a Russian text phrase.
code/modules/organs/limbs.dm

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ROdenFL ROdenFL changed the title wounds wounds and examine translate Feb 11, 2025
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ROdenFL ROdenFL marked this pull request as ready for review February 12, 2025 12:48
Comment on lines -295 to -296
var/list/no_exclude = list("gaping wound", "big gaping wound", "massive wound", "large bruise",\
"huge bruise", "massive bruise", "severe burn", "large burn", "deep burn", "carbonised area")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а че, куда это пропало

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не придумал как адаптировать what might be

code/modules/mob/living/carbon/human/human_attackhand.dm Outdated Show resolved Hide resolved
code/modules/mob/living/carbon/human/human_attackhand.dm Outdated Show resolved Hide resolved
code/modules/mob/living/carbon/human/human_attackhand.dm Outdated Show resolved Hide resolved
@@ -105,6 +105,8 @@
if(owner)
forceMove(owner)

ru_names_rename(ru_names_toml(display_name, override_base = name)) // BANDAMARINES EDIT

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

портируй translate_bodyparts.dm с ТГ

modular/translations/_translations.dm Outdated Show resolved Hide resolved
modular/translations/code/translation_data/ru_wounds.toml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants