Test and fix post compat #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@staltz review if you have time :) otherwise i could pass to mix probably |
|
damn that's not something i expected to fail |
|
so uugh code seems to be supposed to allow importing db1 and db2 at the same time? which breaks with this. trying out removing post compat from the default imports |
|
yay works now |
|
i guess you can argue this is a major version since it changes the default imports but eeh no one uses those anyway |
|
@staltz done for real now |
Benchmark results
|
mixmix
approved these changes
Nov 6, 2023
| @@ -18,7 +18,7 @@ mkdirp.sync(dir) | |||
|
|
|||
| const keys = ssbKeys.loadOrCreateSync(path.join(dir, 'secret')) | |||
|
|
|||
| const sbot = SecretStack({ appKey: caps.shs }).use(require('../')).call(null, { | |||
| const sbot = SecretStack({ appKey: caps.shs }).use(require('../')).use(require('../compat/post')).call(null, { | |||
There was a problem hiding this comment.
because db.post.value is used further down in these tests
staltz
reviewed
Nov 6, 2023
| @@ -8,6 +8,5 @@ module.exports = [ | |||
| require('ssb-box'), | |||
| require('ssb-box2'), | |||
| require('./compat/publish'), | |||
| require('./compat/post'), | |||
There was a problem hiding this comment.
This is a breaking change, so be careful to make a new major version.
|
v8.0.0 |
Benchmark results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ssbc/ssb-tribes#105
Trying to remove db1 completely from ssb-tribes, apparently some test runs replicate and that depends on
sbot.post. But the compat plugin was only providingsbot.db.post. I also added a test.