Add test for delete + reindex + block #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staltz
approved these changes
Aug 23, 2022
There was a problem hiding this comment.
Yeah, this is a good test to have, with all the deleteFeed and compact and so forth. I put a few cosmetic suggestions.
In Manyverse, I might try to use an ssb-fixtures dataset to see if that helps with a shorter dev cycle. It doesn't matter if the peer can actually replicate anything or not, we just need to monitor ebt.request calls for blocked peers.
|
I left this as a draft mostly to share how I tested, not sure if we need to commit this, thanks for review in any case. Good to double check that the tests are correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@staltz I tried different ways of reproducing the bug but can't seem to make it trigger. This PR the latest version I tried. I also tried restarting some of the other nodes. Alice does the correct thing if someone tries to tell it about new stuff on a blocked feed (notes), it sends a -1 back. And Alice is not calling request on reindexing, as you tested. You can see I added
ebt: logging: true. Maybe that will tell us what is going on. I know that patchwork is running a very old version of ebt. I'm not sure if there if that could it, there are some checks in EBT (not ssb-ebt) to prevent the worst kind of errors. Anyway logs should shed some light on this :-)