Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to specify IP of known Distribution Point - similar to pxethief option 2 #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Mayyhem
Copy link

@Mayyhem Mayyhem commented Oct 16, 2023

Updated pxethiefy to allow the user to specify the IP address of a PXE-enabled distribution point instead of locating a DHCP server first. Tested in a lab with a PXE-enabled distribution point. I have not tested explore via interface after these changes due to lack of support in my lab.

@csandker
Copy link
Contributor

Hey @Mayyhem,
sorry for the late reply. I've got this on my list to run this in my Lab and then merge, might take me a few more days though.

Thanks for the contribution ;)

@xopham
Copy link

xopham commented Oct 25, 2023

@Mayyhem thanks for the contribution 🙏 we are a bit short on capacity atm, so we are taking a bit here.
However, the changes seem small enough. If @csandker confirms I am happy to merge the PR.

Otherwise, @bka-dev might be able to take a look at a later point.

@csandker
Copy link
Contributor

@Mayyhem we decided it's best to give pxethiefy a new home as I can't maintain the project here any longer. Could you open up a new PR here: https://github.com/csandker/pxethiefy

Also: There are some bits I've messed up, which I will fix after your PR, so thanks for pushing this ;)

@Mayyhem
Copy link
Author

Mayyhem commented Oct 30, 2023

Sounds good I'll do that now, thanks!

@csandker
Copy link
Contributor

csandker commented Nov 1, 2023

All done and merged here: https://github.com/csandker/pxethiefy

This PR can be closed now @xopham

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants