fix: tests and knip

sshivaditya2019 · Oct 12, 2024 · e37f585 · e37f585
1 parent dd4c334
commit e37f585
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 25 deletions.
diff --git a/.github/knip.ts b/.github/knip.ts
@@ -6,7 +6,7 @@ const config: KnipConfig = {
   ignore: ["src/types/config.ts", "**/__mocks__/**", "**/__fixtures__/**"],
   ignoreExportsUsedInFile: true,
   // eslint can also be safely ignored as per the docs: https://knip.dev/guides/handling-issues#eslint--jest
-  ignoreDependencies: ["eslint-config-prettier", "eslint-plugin-prettier", "@mswjs/data"],
+  ignoreDependencies: ["eslint-config-prettier", "eslint-plugin-prettier"],
   eslint: true,
 };
 

diff --git a/README.md b/README.md
@@ -30,7 +30,7 @@ plugins:
 ```sh
 # OpenAI API key
 OPENAI_API_KEY=your-api-key
-UBIQUITY_OS_APP_SLUG="UbiquityOS"
+UBIQUITY_OS_APP_NAME="UbiquityOS"
 
 ```
 

diff --git a/src/handlers/ask-gpt.ts b/src/handlers/ask-gpt.ts
@@ -36,7 +36,7 @@ export async function askQuestion(context: Context, question: string) {
  **/
 export async function askGpt(context: Context, question: string, formattedChat: string[]): Promise<CompletionsType> {
   const {
-    env: { UBIQUITY_OS_APP_SLUG },
+    env: { UBIQUITY_OS_APP_NAME },
     config: { model, similarityThreshold },
   } = context;
   let similarComments: CommentSimilaritySearchResult[] = [];
@@ -70,7 +70,7 @@ export async function askGpt(context: Context, question: string, formattedChat:
     rerankedText,
     formattedChat,
     ["typescript", "github", "cloudflare worker", "actions", "jest", "supabase", "openai"],
-    UBIQUITY_OS_APP_SLUG
+    UBIQUITY_OS_APP_NAME
   );
 }
 

diff --git a/src/helpers/format-chat-history.ts b/src/helpers/format-chat-history.ts
@@ -1,4 +1,3 @@
-import { ChatCompletionMessageParam } from "openai/resources";
 import { Context } from "../types";
 import { StreamlinedComment, StreamlinedComments } from "../types/gpt";
 import { createKey, streamlineComments } from "../handlers/comments";
@@ -156,19 +155,3 @@ function createComment(comment: StreamlinedComments) {
 function createSpecOrBody(specOrBody: string) {
   return `${specOrBody}\n`;
 }
-
-/**
- * Creates a chat history array from the formatted chat string.
- *
- * @param formattedChat - The formatted chat string.
- * @returns An array of ChatCompletionMessageParam objects representing the chat history.
- */
-export function createChatHistory(formattedChat: string) {
-  const chatHistory: ChatCompletionMessageParam[] = [];
-  const userMessage: ChatCompletionMessageParam = {
-    role: "user",
-    content: formattedChat,
-  };
-  chatHistory.push(userMessage);
-  return chatHistory;
-}
diff --git a/src/plugin.ts b/src/plugin.ts
@@ -38,10 +38,10 @@ export async function plugin(inputs: PluginInputs, env: Env) {
 export async function runPlugin(context: Context) {
   const {
     logger,
-    env: { UBIQUITY_OS_APP_SLUG },
+    env: { UBIQUITY_OS_APP_NAME },
   } = context;
   const question = context.payload.comment.body;
-  const slugRegex = new RegExp(`@${UBIQUITY_OS_APP_SLUG} `, "gi");
+  const slugRegex = new RegExp(`@${UBIQUITY_OS_APP_NAME} `, "gi");
   if (!question.match(slugRegex)) {
     logger.info("Comment does not mention the app. Skipping.");
     return;

diff --git a/src/types/env.ts b/src/types/env.ts
@@ -13,7 +13,7 @@ dotenv.config();
  */
 export const envSchema = T.Object({
   OPENAI_API_KEY: T.String(),
-  UBIQUITY_OS_APP_SLUG: T.String(),
+  UBIQUITY_OS_APP_NAME: T.String(),
   VOYAGEAI_API_KEY: T.String(),
   SUPABASE_URL: T.String(),
   SUPABASE_KEY: T.String(),

diff --git a/tests/main.test.ts b/tests/main.test.ts
@@ -270,7 +270,7 @@ function createContext(body = TEST_SLASH_COMMAND) {
     logger: new Logs("debug"),
     config: {},
     env: {
-      UBIQUITY_OS_APP_SLUG: "UbiquityOS",
+      UBIQUITY_OS_APP_NAME: "UbiquityOS",
       OPENAI_API_KEY: "test",
     },
     adapters: {