Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new dbplyr style of unique table name #148

Merged
merged 7 commits into from
Oct 4, 2024

Conversation

RasmusSkytte
Copy link
Contributor

@RasmusSkytte RasmusSkytte commented Jul 22, 2024

Intent

This PR updates unique_table_names() to the new dbplyr style of using random letters

This method does not rely on the creation and tracking of options which simplifies the footprint of the function.

Approach

Letters and numbers sampled to form the unique component of the table name.

Known issues

N/A

Checklist

  • The PR passes all local unit tests
  • I have documented any new features introduced
  • If the PR adds a new feature, please add an entry in NEWS.md
  • A reviewer is assigned to this PR

@RasmusSkytte RasmusSkytte self-assigned this Jul 22, 2024
@RasmusSkytte RasmusSkytte requested review from a team, SofiaOtero and LasseEngboChr and removed request for a team July 22, 2024 14:14
@RasmusSkytte RasmusSkytte marked this pull request as ready for review July 22, 2024 14:15
@RasmusSkytte RasmusSkytte added this to the v0.5 milestone Jul 23, 2024
@RasmusSkytte RasmusSkytte merged commit c3025bd into main Oct 4, 2024
27 checks passed
@RasmusSkytte RasmusSkytte deleted the feature/update-unique_table_name branch October 4, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants