Include the expect_identical_linter
#127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RasmusSkytte
added
enhancement
RasmusSkytte
force-pushed
the
feature/use-expect_identical
branch
from
d5dea92
to
3c962c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
This PR introduces the
expect_identical_linterto our set of linters.This should help make our tests even more specific.
Approach
Exception removed for the
expect_identical_linter.Existing
expect_equalconverted toexpect_identicalunless we are comparing functions.Functions also carry their own environment, which makes them equal but not "identical".
Known issues
N/A
Checklist
NEWS.md