-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DiseasyModel #36
DiseasyModel #36
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
==========================================
- Coverage 87.19% 85.79% -1.41%
==========================================
Files 8 9 +1
Lines 914 929 +15
==========================================
Hits 797 797
- Misses 117 132 +15 ☔ View full report in Codecov by Sentry. |
6f9c280
to
977bc06
Compare
977bc06
to
d5fa480
Compare
5de7bd2
to
4a062f4
Compare
ae90d78
to
cca4b0c
Compare
bb989b8
to
c23f071
Compare
7961ac4
to
f97b07d
Compare
9748078
to
0b866fd
Compare
Co-authored-by: Lasse Engbo Christiansen <[email protected]>
Co-authored-by: Lasse Engbo Christiansen <[email protected]>
Co-authored-by: Lasse Engbo Christiansen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have a look at suggestions and comments
Intent
This PR adds the DiseasyModel class (fixing #26)
Approach
Exported from NGC and adapted.
This class (now fully documented) forms the basis for all model templates in
diseasy
.To do this, it includes the ability to contain instances of functional modules (presently,
DiseasySeason
,DiseasyActivity
andDiseasyObservables
).These can be added either in the constructor of through the
$load_module()
function (implemented inDiseasyBaseModule
notDiseasyModel)
.Beyond containing these instances of functional modules,
DiseasyModel
defines the "API" for the model templates to use.That is, it provides the functions:
$get_results()
$get_training_data()
and it implements the
$parameters
list of parameters for the model.The implementation of
$load_module()
inDiseasyBaseModule
is also refactored and generalized to load arbitrary modules and not justDiseasyObservables
.Now, if any class includes the private field
$.Diseasy<Module>
then$load_module()
can populate this field if the provided module has the class "<Module>" (e.g.DiseasyObservables
).Known issues
The tests forDiseasySeason
andDiseasyObservables
are failing.This is due to the tests being run across alldiseasystores
which as introduced errors.This is being fixed in a different PR:Disable test across all diseasystores #99The R-CMD-Check without dependencies is failing.This is being fixed in a different PRGracefeully handle missing suggests #102We may want to wait for #101 and #111 to be merged before merging this PR.
This way, we can add these new functional modules to
DiseasyModel
.Checklist
NEWS.md