feat - validator redirects #5
Conversation
cmd/ssv-rewards/calc.go
Outdated
| ownerRedirectsSupport := len(mechanics.OwnerRedirects) > 0 | ||
| validatorRedirectsSupport := len(mechanics.ValidatorRedirects) > 0 |
There was a problem hiding this comment.
we're not populating the tables here like in recipientParticipations, so it seems that if you call this func before, the redirections will be missing
i wouldn't mind just copying the code from below over here, or maybe creating a function for prepareRedirections that returns both if they're enabled (bool, bool) and populates them ifn eeded
There was a problem hiding this comment.
@olegshmuelov Moshe is out how can i recreate this? Do a validator redirect with no owner redirects?
There was a problem hiding this comment.
we're not populating the tables here like in
recipientParticipations, so it seems that if you call this func before, the redirections will be missingi wouldn't mind just copying the code from below over here, or maybe creating a function for prepareRedirections that returns both if they're enabled (bool, bool) and populates them ifn eeded
Good catch! I extracted the logic preparing the redirections into a new function called prepareRedirections.
This way, both validatorParticipations and recipientParticipations will have the same logic to fill in the redirection tables and thus cannot miss any redirections.
see e9192f0
No description provided.